CreateProcess needs CREATE_UNICODE_ENVIRONMENT
#903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> If the environment block pointed to by lpEnvironment contains > Unicode characters, be sure that dwCreationFlags includes > CREATE_UNICODE_ENVIRONMENT. If this parameter is NULL and the > environment block of the parent process contains Unicode characters, > you must also ensure that dwCreationFlags includes > CREATE_UNICODE_ENVIRONMENT. From [doc1][]. > If this flag is set, the environment block pointed to by > lpEnvironment uses Unicode characters. Otherwise, the environment > block uses ANSI characters. From [doc2][]. This was forgotten from PR ocsigen#843 that switched to Unicode strings on Windows (including the environment). [doc1]: https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-createprocessw [doc2]: https://docs.microsoft.com/en-us/windows/win32/procthread/process-creation-flags#CREATE_UNICODE_ENVIRONMENT
smorimoto
approved these changes
Nov 19, 2021
|
Thanks @MisterDA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From doc1.
From doc2.
This was forgotten from PR #843 that switched to Unicode strings on
Windows (including the environment). I noticed it when reading code
from win32unix.